Add ReturnTypeWillChange to FrameCollection #706
Conversation
Fix PHP 8.1 compatibility
There was a problem hiding this comment.
Thank you, @kylekatarnls! Indeed, we want something like that.
| public function __serialize(): array | ||
| { | ||
| return $this->frames; | ||
| } | ||
|
|
||
| public function __unserialize(array $serializedFrames): void | ||
| { | ||
| $this->frames = $serializedFrames; | ||
| } |
There was a problem hiding this comment.
Are these related to the ReturnTypeWillChange or is this an accidental addition?
There was a problem hiding this comment.
This is also needed for PHP 8.1 compatibility because Serializable is deprecated.
|
Guys, this merge destroys PHP 5 compatibility because of the return types. |
|
GitHub Actions started from PHP 7.0, I didn't notice the composer.json still supports PHP 5. If PHP 5 is still meant to be supported, then it should be added to GitHub Actions to be tested. But maybe it's a mistake in the composer.json. Actually I don't think it will be possible to be compatible with both PHP 5 and 8.1 without deprecation/warning notices in the same branch. And I know it's not what you want to hear but PHP 8 is out now, so it's really time to drop PHP 5. If you decide not to upgrade PHP, then the more consistent move could be also to lock the |
|
I agree that the existing support for PHP 5, even though untested, is surprising, but it is what is announced in the composer.json. As you can see from #504 it has been discussed long ago to drop PHP 5 support, but somehow never happened. |
|
I think whoops must be able to run in all PHP versions (from PHP 5), PHP 5 is still there in the market and a lot of websites still use it specially in development environment (including me). |
|
just have a look at the master branch. denis already added testcoverage 7bf80a3 |
"A lot" is probably exaggerated: It's completely negligible in proportion. And if you don't feel using PHP 5 is a problem, you should feel OK to not be up to date with the latest filp/whoops neither 🤷 |
Fix PHP 8.1 compatibility